This repository was archived by the owner on Feb 24, 2020. It is now read-only.
-
Couldn't load subscription status.
- Fork 881
stage1: update to systemd v225 on the coreos flavor #2308
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c972772 to
0c6be29
Compare
0c6be29 to
4d34df5
Compare
|
Tests don't pass on Semaphore because we're testing |
|
tests/README.md could be updated from v222 to v225, and maybe a couple of others. Visible with: |
tests/rkt_exit_test.go
Outdated
| // include the exit status propagation code. | ||
| // TODO(iaguis): we should expect 5 as the exit status when we update to v229 | ||
| waitOrFail(t, child, 0) | ||
| // Since systend v227, the exit status is propagated from the app to rkt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/systend/systemd
The exit status can be propagated from apps by using "systemctl exit" since systemd v227. rkt checks the systemd version to know whether it can use "systemctl exit". However, systemd from coreos is back porting the patches, so we skip the systemd version check on the coreos flavor. See rkt#1460
Now that the exit code is propagated from the app to rkt, returning 42 from /inspect would make the rkt command fails. The API service tests don't actually test the exit code, so it is safe to remove that.
This reverts commit e9238f9. Now that we updated to v225 on flavor coreos, We don't support old systemd versions so we can actually check for the exit status everywhere.
4d34df5 to
790ff03
Compare
|
LGTM if green |
b08ecfc to
4ba22b5
Compare
558593e to
e870289
Compare
gcc-4.8 crashes when building systemd v229.
e870289 to
67f9c1d
Compare
|
Grün! \o/ |
|
LGTM! |
This was referenced Mar 24, 2016
Open
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1460
Fixes #2264
Fixes #1556
Closes #2295