This repository was archived by the owner on Feb 24, 2020. It is now read-only.
kvm: Improving lkvm performance #2321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stage1/init/kvm/resources.go
Outdated
| // In case when number of specified cpus is greater than | ||
| // number or when cpus aren't specified, we set number | ||
| // of logical cpus as a limit. | ||
| available_cpus := int64(runtime.NumCPU()) |
There was a problem hiding this comment.
do we need operate on int64 if in findResources bytes are converted to megabytes ?
There was a problem hiding this comment.
prefer camelcase - availableCpus
There was a problem hiding this comment.
@jonboulle, @woodbor sure
b07fc88 to
708ab5d
Compare
When lkvm is using more vcpus than platform has got, then VMs spinning up is very slow. This patch blocks this behavior and when user choose more vcpus then platform has cores, then number of cpus is set to number of cores
708ab5d to
dead82a
Compare
|
Review request |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When lkvm is using more vcpus than platform has got, then VMs
spinning up is very slow. This patch blocks this behavior and
when user choose more vcpus then platform has cores, then
number of cpus is set to number of cores