This repository was archived by the owner on Feb 24, 2020. It is now read-only.
stage1/init: return exit code 1 on error #2383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On error, stage1/init was returning a non-zero value between 1 and 7. It was useful for debugging to return a different value when stage1 was not able to print any error messages. But it is not the case anymore: stage1 can write on stdout/stderr nowadays.
|
Argh, great news for me. |
|
squash the commits together for the sake of the tests? |
|
LGTM |
|
@s-urbaniak wanna pull the merge trigger? |
|
ok, it's an honor to do so :-) |
|
🎆 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On error, stage1/init was returning a non-zero value between 1 and 7. It
was useful for debugging to return a different value when stage1 was not
able to print any error messages. But it is not the case anymore: stage1
can write on stdout/stderr nowadays.
/cc @s-urbaniak PTAL