This repository was archived by the owner on Feb 24, 2020. It is now read-only.
docs: clean up English in hacking guide #2395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation/hacking.md
Outdated
| To build this stage1 image, pass `kvm` to `--with-stage1-flavors` parameter in `./configure` | ||
|
|
||
| This will generate stage1 with embedded kernel and kvmtool to start pod in virtual machine. | ||
| This will generate stage1 with an embedded kernel and kvmtool to start pods in virtual machine. |
There was a problem hiding this comment.
"in virtual machines" or "in a virtual machine"?
There was a problem hiding this comment.
if pods are in plural form - first one.
|
thanks, fixed |
|
LGTM |
|
Semaphore fails because the patch is not rebased. But that's not a big issue for documentation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.