Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

Conversation

@jellonek
Copy link
Contributor

rkt status needs ppid file, which was removed in #2396

@alban
Copy link
Member

alban commented Apr 13, 2016

rkt status uses p.getPID():

// getPID returns the pid of the stage1 process that started the pod.
func (p *pod) getPID() (int, error) {
    pid, err := p.readIntFromFile("ppid")
    if err != nil {
        return -1, err
    }
    return pid, nil
}

It seems to me that the bug is in getPID() above. Shouldn't getPID() use "pid" and fallback on "ppid"?

@alban
Copy link
Member

alban commented Apr 13, 2016

LGTM if Semaphore is green and if it works for kvm.

@alban alban merged commit 84e07dd into rkt:master Apr 13, 2016
@jellonek jellonek deleted the jell/fix_pid_files branch April 14, 2016 07:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants