run: add user/group app flags #2419
Conversation
|
@steveej PTAL (your turn now) ;-) |
|
semaphail? |
CHANGELOG.md
Outdated
|
|
||
| #### New features and UX changes | ||
|
|
||
| - Add `--user`/`--group` option to rkt run/prepare ([#xxx](https://github.com/coreos/rkt/pull/xxx)). This option allows overriding the user/group. |
There was a problem hiding this comment.
This option allows overriding the user/group specified in the image manifest.
58fde34 to
4b4cd20
Compare
|
LGTM on green |
tests/rkt_run_user_group_test.go
Outdated
| ctx := testutils.NewRktRunCtx() | ||
| defer ctx.Cleanup() | ||
|
|
||
| t.Logf("Running test: user, group") |
|
one nitpick & LGTM on green |
6abbaaa to
ff58a55
Compare
This adds --user and --group app flags to override the user and/or the group for the run subcommand. Fixes rkt#1920
|
|
||
| #### New features and UX changes | ||
|
|
||
| - Add `--user`/`--group` option to rkt run/prepare ([#2419](https://github.com/coreos/rkt/pull/2419)). This option allows overriding the user/group specified in the image manifest. |
There was a problem hiding this comment.
We're not really consistent on this... https://github.com/coreos/rkt/blob/master/Documentation/commands.md#global-options
|
This is green now and the review changes are docs so we can merge it right-away if it looks good. |
| | `--stage1-from-dir` | `` | A stage1 image file inside the default stage1 images directory | Image to use as stage1 | | ||
| | `--store-only` | `false` | `true` or `false` | Use only available images in the store (do not discover or download from remote URLs). See [image fetching behavior](../image-fetching-behavior.md) | | ||
| | `--volume` | `` | Volume syntax (`NAME,kind=KIND,source=PATH,readOnly=BOOL`). See [Mount Volumes into a Pod](run.md#mount-volumes-into-a-pod) | Volumes to make available in the pod | | ||
| | `--user` | none | username or UID | user override for the preceding image (example: '--user=user') | |
There was a problem hiding this comment.
Capitalize first letters in "username" and "user". Like it is done in other table rows.
With a working doc-only-change-detection that would make a lot of sense :-) |
|
Thanks @s-urbaniak! please follow-up with the doc changes. |
| cmdPrepare.Flags().Var((*appExec)(&rktApps), "exec", "override the exec command for the preceding image") | ||
| cmdPrepare.Flags().Var((*appMount)(&rktApps), "mount", "mount point binding a volume to a path within an app") | ||
| cmdPrepare.Flags().Var((*appAsc)(&rktApps), "signature", "local signature file to use in validating the preceding image") | ||
| cmdPrepare.Flags().Var((*appUser)(&rktApps), "user", "user override for the preceding image (example: '--user=user')") |
There was a problem hiding this comment.
Maybe we could consider rather creating a function that adds these flags to the passed flagSet? That way we can avoid the repeating of descriptions and others.
and the non-doc changes 🍭 |
|
is there an issue for this? On Thu, Apr 14, 2016 at 3:10 PM, Stefan Junker [email protected]
|
Welp, #1920 (see the OP 😃) |
|
GitHub didn't let my email reply to a specific comment. Bah humbug. I was talking about #2419 (comment) |
|
|
<3 On Thu, Apr 14, 2016 at 4:18 PM, Iago López Galeiras <
|
This adds --user and --group app flags to override the user and/or the
group for the run subcommand.
Fixes #1920