tests: rkt-monitor add new statistics #2587

borqosky · 2016-05-06T12:14:00Z

New statistics for load average and boot/stop time measure of container.
Differences are measured in a nanoseconds. Godeps updated as well.

borqosky · 2016-05-10T11:15:50Z

related with #2556 , @dgonyeo : review request

jellonek · 2016-05-10T11:31:17Z

tests/rkt-monitor/main.go

 		fmt.Fprintf(os.Stderr, "cleanup failed: %v\n", err)
 	}
-
+	containerStoped := time.Now()


It would be nice if you will add there empty line as in L158

Stoped -> Stopped

jellonek · 2016-05-10T11:31:32Z

LGTM

pskrzyns · 2016-05-10T12:43:44Z

LGTM

jonboulle · 2016-05-10T15:55:39Z

Documentation/benchmarks/rkt-1-4-0-benchmarks.md

 systemd(18515): seconds alive: 9  avg CPU: 0.000000%  avg Mem: 4 mB  peak Mem: 4 mB
 systemd-journal(18517): seconds alive: 9  avg CPU: 88.397098%  avg Mem: 7 mB  peak Mem: 7 mB
 worker(18521): seconds alive: 9  avg CPU: 7.330367%  avg Mem: 5 mB  peak Mem: 6 mB
+load average in a container: Load1: 0.390000 Load5: 0.120000 Load15: 0.080000


The string doesn't match up with what's printed below.. did you run it?

getUsage grab statistics not every time in the same order - IMHO that's why strings don't match each other.

I just mean the format of the string here https://github.com/coreos/rkt/pull/2587/files#diff-07b54b89d53b286f0316e52cfcec59afR183 is different, which suggests that you artificially created these outputs rather than running the code ;-)

ping @woodbor

cgonyeo · 2016-05-10T16:51:43Z

LGTM

Follow rkt#2587. Add flag for command validatr as well

Follow rkt#2587. Add flag for command validate as well

jonboulle · 2016-05-12T13:10:29Z

tests/rkt-monitor/main.go


+	loadAvg, err := load.Avg()
+
+	containerStoping := time.Now()


also Stoping -> Stopping

do you just want to close this PR in favour of your other one?

iaguis · 2016-05-12T15:06:35Z

Not ready yet, moving.

borqosky · 2016-05-13T10:54:05Z

@iaguis @jonboulle : IMHO, it's really difficult to find why gofmt is failing (there is no output), and that's because -s flag is used during make unit-check. gofmt without any flags on local didn't return any errors

jellonek · 2016-05-13T11:13:40Z

IMO this deserves for note somewhere in docs. Do we have any docs about hacking/devel, with description how to prepare initial setup for developer machine targeted to work on rkt?

At Intel we have new guy who already prepared such doc. Are You interested in this?
(info about such required gofmt parameters would be quite useful in this doc, among other common pitfalls).

pskrzyns · 2016-05-19T21:36:32Z

Needs some additional work

borqosky · 2016-05-20T09:32:43Z

@dgonyeo : review request

jonboulle · 2016-05-20T09:48:56Z

@lucab mind doing a review?

lucab · 2016-05-20T20:02:46Z

Godeps/Godeps.json

 		},
+		{
+			"ImportPath": "github.com/shirou/gopsutil/load",
+			"Comment": "v2.0.0-10-g9ef3410",


Is there any reason why we need this specific commit? If so, can we ask upstream to tag a release with this?

That's the version of gopsutil already packaged with rkt. Looking now, it appears that gopsutil does have tagged releases, so we should switch to using that. If @woodbor doesn't want to make the switch in this PR I can put together a separate one to switch the version used.

@dgonyeo Please do

lucab · 2016-05-20T20:36:42Z

From my side, just a bunch of non-major comments inline. I'm not tagging it as reviewed here, as it is my understanding that @dgonyeo will then take care of landing it.

cgonyeo · 2016-05-23T20:27:25Z

tests/rkt-monitor/main.go

+	flagDuration     string
+	flagShowOutput   bool
+	saveToCsv        bool
+	repetitionNumber int


Maybe prepend these added variables with flag to be consistent with the other flag variables?

New statistics for load average and boot/stop time measure of container. Diferences are measured in a nanoseconds. Godeps updated as well. Change network from 'host' to 'default-restricted' since kvm flavor can't create this type.

Save data to csv - useful for plot a graph of usage. Add a flag command for additional validation. Fix some docs regarding to rkt-monitor.

jonboulle · 2016-05-26T13:58:52Z

LGTM, we can follow up with anything necessary. Thanks for the patch @woodbor !

borqosky force-pushed the rkt_monitor_new_metrics branch from a23af4c to 5836509 Compare May 9, 2016 07:08

borqosky changed the title ~~tests: rkt-monitor add new statistics~~ [WIP]tests: rkt-monitor add new statistics May 9, 2016

borqosky force-pushed the rkt_monitor_new_metrics branch from 5836509 to cbaa7f0 Compare May 9, 2016 07:40

borqosky changed the title ~~[WIP]tests: rkt-monitor add new statistics~~ tests: rkt-monitor add new statistics May 9, 2016

borqosky force-pushed the rkt_monitor_new_metrics branch from cbaa7f0 to 4135c59 Compare May 10, 2016 09:55

jellonek reviewed May 10, 2016
View reviewed changes

jonboulle reviewed May 10, 2016
View reviewed changes

jonboulle added area/performance needs/some-changes labels May 11, 2016

borqosky force-pushed the rkt_monitor_new_metrics branch from 4135c59 to 328c2f7 Compare May 11, 2016 09:32

borqosky pushed a commit to intelsdi-x/rkt that referenced this pull request May 12, 2016

tests: save interval data measures to csv file

7adb4da

Follow rkt#2587. Add flag for command validatr as well

borqosky pushed a commit to intelsdi-x/rkt that referenced this pull request May 12, 2016

tests: save interval data measures to csv file

a1f61f5

Follow rkt#2587. Add flag for command validatr as well

borqosky pushed a commit to intelsdi-x/rkt that referenced this pull request May 12, 2016

tests: save interval data measures to csv file

de3df9c

Follow rkt#2587. Add flag for command validate as well

borqosky mentioned this pull request May 12, 2016

tests: save interval data measures to csv file #2617

Closed

borqosky pushed a commit to intelsdi-x/rkt that referenced this pull request May 12, 2016

tests: save interval data measures to csv file

fc95b85

Follow rkt#2587. Add flag for command validate as well

jonboulle added this to the v1.6.0 milestone May 12, 2016

jonboulle reviewed May 12, 2016
View reviewed changes

borqosky force-pushed the rkt_monitor_new_metrics branch 2 times, most recently from 36a22f6 to 8dd70d9 Compare May 12, 2016 14:44

iaguis modified the milestones: v1.7.0, v1.6.0 May 12, 2016

borqosky force-pushed the rkt_monitor_new_metrics branch from 8dd70d9 to efe17ae Compare May 13, 2016 10:48

borqosky force-pushed the rkt_monitor_new_metrics branch 2 times, most recently from eef17a8 to 8f17481 Compare May 17, 2016 12:13

borqosky changed the title ~~tests: rkt-monitor add new statistics~~ [WIP]tests: rkt-monitor add new statistics May 18, 2016

borqosky force-pushed the rkt_monitor_new_metrics branch from 0c2ff0a to 24bb810 Compare May 19, 2016 11:41

borqosky force-pushed the rkt_monitor_new_metrics branch from 24bb810 to f4257f8 Compare May 20, 2016 08:59

borqosky changed the title ~~[WIP]tests: rkt-monitor add new statistics~~ tests: rkt-monitor add new statistics May 20, 2016

jonboulle added needs/review and removed needs/some-changes labels May 20, 2016

lucab reviewed May 20, 2016
View reviewed changes

cgonyeo reviewed May 23, 2016
View reviewed changes

jonboulle added needs/some-changes and removed needs/review labels May 24, 2016

Wlodzimierz Borkowski added 3 commits May 25, 2016 10:10

tests: rkt-monitor add new statistics

18b43b3

New statistics for load average and boot/stop time measure of container. Diferences are measured in a nanoseconds. Godeps updated as well. Change network from 'host' to 'default-restricted' since kvm flavor can't create this type.

tests: save interval data measures to csv file

febc6c6

Save data to csv - useful for plot a graph of usage. Add a flag command for additional validation. Fix some docs regarding to rkt-monitor.

tests: add new flag for repetitions number, docs update

e828bb5

borqosky force-pushed the rkt_monitor_new_metrics branch from f4257f8 to e828bb5 Compare May 25, 2016 08:13

jonboulle removed the needs/some-changes label May 26, 2016

jonboulle merged commit 26e62f5 into rkt:master May 26, 2016

mzylowski deleted the rkt_monitor_new_metrics branch August 1, 2016 14:45

lucab unassigned cgonyeo Apr 5, 2017

tests: rkt-monitor add new statistics #2587

tests: rkt-monitor add new statistics #2587

Uh oh!

Conversation

borqosky commented May 6, 2016

Uh oh!

borqosky commented May 10, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jellonek commented May 10, 2016

Uh oh!

pskrzyns commented May 10, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cgonyeo commented May 10, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iaguis commented May 12, 2016

Uh oh!

borqosky commented May 13, 2016

Uh oh!

jellonek commented May 13, 2016

Uh oh!

pskrzyns commented May 19, 2016

Uh oh!

borqosky commented May 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonboulle commented May 20, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lucab commented May 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonboulle commented May 26, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

borqosky commented May 20, 2016 •

edited

Loading

lucab commented May 20, 2016 •

edited

Loading