This repository was archived by the owner on Feb 24, 2020. It is now read-only.
stage1: fix incorrect splitting function #3541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-urbaniak
approved these changes
Jan 18, 2017
Contributor
s-urbaniak
left a comment
There was a problem hiding this comment.
LGTM, but I am worried that we didn't catch this with a functional test. Do you mind to create a follow-up issue, or, even better, add a test here ;-)
Contributor
Author
|
A good question. Probably this function should output some debugging information we can match on. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR used the wrong splitting function 🙇