This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Add patch to allow build with clang 7.3 #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the -Wno-shift-negative-value flag to Clang. Clang 7.3 was introduced
in OSX with XCode 7.3.
Without this flag, compiling with Clang 7.3 fails with errors such as:
In file included from ../src/elements.h:32:
../src/objects.h:5252:44: error: shifting a negative signed value is undefined
[-Werror,-Wshift-negative-value]
static const int kElementsKindMask = (-1 << kElementsKindShift) &
~~ ^
../src/objects.h:7386:36: error: shifting a negative signed value is undefined
[-Werror,-Wshift-negative-value]
(~kMaxCachedArrayIndexLength << kArrayIndexHashLengthShift) |
~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
2 errors generated.
Some versions of Ruby used an old Bundler version.
This was referenced Apr 24, 2016
|
@cowboyd it would be great if this could be merged, I already had to |
|
Thank you for the contribution! |
|
You are welcome @ignisf. Any idea when the new gem could be published? |
|
I usually leave releasing the gem to @cowboyd, as I have no way of producing osx binaries and it's a bad idea to leave all osx users to deal with the touchy build process of v8. So... No, no idea 😕... |
|
@ignisf I could give you the darwin14 / darwin15 builds if that helps! |
|
Thank you, but I would not publish binaries made on a system I can't trust. |
|
Which is a relief for all of us :)
So let's wait for @cowboyd.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the -Wno-shift-negative-value flag to Clang. Clang 7.3 was introduced
in OSX with XCode 7.3.
Without this flag, compiling with Clang 7.3 fails with errors such as: