feat(ci): harden #90

avivkeller · 2025-07-28T12:58:29Z

This PR hardens the CI by explicitly pinning all GitHub actions to their exact commit SHAs.

Summary by CodeRabbit

Chores
- Added automated dependency update configuration with monthly checks.
- Updated GitHub Actions workflows to use specific action versions for improved reliability.
- Enhanced workflow security by disabling credential persistence in relevant steps.
- Improved handling of authentication tokens in the publishing workflow.

coderabbitai · 2025-07-28T12:58:38Z

Walkthrough

This update introduces a new Dependabot configuration and modifies several GitHub Actions workflows. The workflows now reference specific commit SHAs for third-party actions instead of version tags, and some steps have updated parameters for security and clarity. No changes are made to the core application logic or exports.

Changes

Cohort / File(s)	Change Summary
Dependabot Configuration `.github/dependabot.yml`	Adds Dependabot config to check `github-actions` dependencies monthly at the repo root.
Build Workflow Updates `.github/workflows/build.yml`	Updates action versions to specific SHAs for checkout, setup-node, and cache; adds `persist-credentials: false` to checkout.
CLA Workflow Update `.github/workflows/cla.yml`	Updates `contributor-assistant/github-action` to use a specific commit SHA for v2.6.1.
Publish Workflow Updates `.github/workflows/publish.yml`	Updates action versions to specific SHAs; disables credential persistence in checkout; changes token handling to use environment variable.
Test Workflow Updates `.github/workflows/test.yml`	Updates action versions to specific SHAs; disables credential persistence in checkout.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A bunny hopped through YAML fields,
Updating hashes, securing shields.
Dependabot arrives to scan with care,
Actions pinned with hashes rare.
Credentials tucked safely away—
The workflows now are bright and gay!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch ci/harden

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-07-28T12:58:42Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

avivkeller · 2025-07-28T12:58:54Z

I have read the CLA Document and I hereby sign the CLA

coderabbitai

Actionable comments posted: 3

🧹 Nitpick comments (2)

.github/dependabot.yml (1)

1-6: Consider tightening update cadence and adding security-focused labels

Monthly checks are fine for low-risk projects, but GitHub-Action CVEs often need faster turnaround. A weekly (or even daily) schedule plus a labels: section (e.g. security, dependencies) improves visibility and triage speed.
.github/workflows/publish.yml (1)
36-39: Ensure the auth token never leaks to logs

Writing the token via echo is okay because GitHub redacts secrets, but adding the --no-echo style heredoc removes even TRACE-level exposure:
-      - run: echo "//registry.npmjs.org/:_authToken=$NODE_AUTH_TOKEN" > ~/.npmrc
+      - run: |
+          cat <<EOF > ~/.npmrc
+//registry.npmjs.org/:_authToken=${NODE_AUTH_TOKEN}
+EOF

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b471390 and dea7ada.

📒 Files selected for processing (5)

.github/dependabot.yml (1 hunks)
.github/workflows/build.yml (1 hunks)
.github/workflows/cla.yml (1 hunks)
.github/workflows/publish.yml (2 hunks)
.github/workflows/test.yml (1 hunks)

🔇 Additional comments (7)

.github/workflows/build.yml (2)

21-23: Good call pinning actions/checkout and disabling credential persistence
Immutable SHAs + persist-credentials: false mitigate supply-chain attacks and token bleed.

31-37: Cache action correctly pinned – LGTM
Pinning actions/cache to a SHA is consistent with the hardening goal.

.github/workflows/test.yml (2)

8-10: Checkout step hardened correctly
Same rationale as the build workflow—looks good.

18-24: Cache action SHA pin approved
Consistent with security strategy.

.github/workflows/publish.yml (2)

12-14: Checkout pin + no credentials: good
Reduces risk of token exfiltration during releases.

24-31: Cache action correctly pinned
No issues spotted.

.github/workflows/cla.yml (1)

15-15: CLA Assistant pinned – solid
Locking the action to a commit aligns with the repo’s hardening goals.

.github/workflows/build.yml

.github/workflows/publish.yml

.github/workflows/test.yml

alfetopito · 2025-09-30T09:14:25Z

Deprecated repo. Moved to https://github.com/cowprotocol/cow-sdk/tree/main/packages/app-data

feat(ci): harden

dea7ada

github-actions bot added a commit that referenced this pull request Jul 28, 2025

@avivkeller has signed the CLA in #90

f686779

coderabbitai bot reviewed Jul 28, 2025

View reviewed changes

.github/workflows/build.yml Show resolved Hide resolved

.github/workflows/publish.yml Show resolved Hide resolved

.github/workflows/test.yml Show resolved Hide resolved

alfetopito closed this Sep 30, 2025

alfetopito deleted the ci/harden branch September 30, 2025 09:14

github-actions bot locked and limited conversation to collaborators Sep 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(ci): harden #90

feat(ci): harden #90

Uh oh!

avivkeller commented Jul 28, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 28, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jul 28, 2025 •

edited

Loading

Uh oh!

avivkeller commented Jul 28, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alfetopito commented Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(ci): harden #90

feat(ci): harden #90

Uh oh!

Conversation

avivkeller commented Jul 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

avivkeller commented Jul 28, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alfetopito commented Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

avivkeller commented Jul 28, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jul 28, 2025 •

edited

Loading