Better handling of same JVM concurrent downloads #2591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the same as Mill's publishLocal, but publishes empty source and javadoc JARs.
4c3ed84 to
f36d161
Compare
f36d161 to
f9fcead
Compare
lefou
added a commit
to lefou/mill
that referenced
this pull request
Dec 2, 2022
lefou
added a commit
to com-lihaoyi/mill
that referenced
this pull request
Dec 2, 2022
See issue coursier/coursier#2603 and PR coursier/coursier#2591 Pull request: #2163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues I'm getting while running locally the repro of com-lihaoyi/mill#2112 (comment).
Likely fixes #1753 (
concurrent downloaderrors are no more thrown)Likely fixes #2022 too (
concurrent downloaderrors are no more thrown)Should fix #1815 (this addresses a race condition, that was making some parallel downloads wipe files freshly written by others).