Set page size for aarch64 Linux binaries to 64k #2641
Conversation
|
Can someone approve the workflows to run? Thanks! |
411908f to
59e9c15
Compare
|
@alexarchambault Can you approve once more? I force pushed because formatting was wrong. |
alexarchambault
left a comment
There was a problem hiding this comment.
Thanks @mkurz! I just hope this won't have unintended consequences (performance-wise, ...)
|
@alexarchambault Besides more memory usage, which can be neglected IMHO, there should hopefully not be a performance penalty. Also this changes really only effects the Linux aarch64 binaries, so nothing changes for the "average" Linux, macOS or Windows users 😉 Would really love to see this in RC5, thanks! |
|
Just to let you know, sbt 1.8.1 just got released, which contains the same page size setting like in this pull request and like scala-cli has now as well: sbt/sbt#7108 |
|
Any reason not to merge this? |
|
@alexarchambault should we merge? |
Fixes #2636, makes coursier run on Linux running on bar metal Apple silicon and also in Linux docker containers within macOS on M1/M2 machines.
Same like we did for scala-ci here: VirtusLab/scala-cli#1726