Always build Linux binaries from the controlled Docker image if we are in the CI #2670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in the CI We used to switch to the Docker environment in case the host environment’s architecture was `x86_64`, but `ubuntu:latest` is currently `amd64`. Now we always use the Docker environment to build the Linux launchers’ binaries when we are in the CI to make sure we don’t depend on the current state of the `ubuntu` image provided by GitHub.
alexarchambault
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to switch to the Docker environment in case the host environment’s architecture was
x86_64, butubuntu:latestis currentlyamd64. Now we always use the Docker environment to build the Linux launchers’ binaries when we are in the CI to make sure we don’t depend on the current state of theubuntuimage provided by GitHub.