Improve output of update command for non-installed applications #2714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested locally: ~~~ text $ ./mill cli.run update dummy-app-id [504/504] cli.run Cannot find installed application 'dummy-app-id' (installation directory is /home/julien/.local/share/coursier/bin). Try running 'cs install dummy-app-id'. ~~~ Fixes coursier#2661
julienrf
commented
Mar 16, 2023
| info.withAppDescriptor(info.appDescriptor.withNameOpt(Some(name))) | ||
| } | ||
| writtenOpt <- | ||
| if (Files.exists(launcher)) |
Collaborator
Author
There was a problem hiding this comment.
This is the important change (the content of the “then-branch” is an exact copy of what we had before). Now, before we try to read the source, we check if the file exists. In case that file does not exist, we immediately return Some(false).
modules/install/src/main/scala/coursier/install/InstallDir.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexandre Archambault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally:
Fixes #2661