feat(AlertProvider): Add noClickAway and noTimeOut prop
#2864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to disable closing when clicking away or waiting the timeout. I moved the handleClose func in a helper file to avoid styleguide messing with func name
BundleMonUnchanged files (3)
No change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
zatteo
approved these changes
Oct 2, 2025
rezk2ll
reviewed
Oct 2, 2025
| message, | ||
| title, | ||
| duration, | ||
| noTimeOut, // eslint-disable-line no-unused-vars |
There was a problem hiding this comment.
comment just above to explain that
| variant="filled" | ||
| elevation={6} | ||
| onClose={handleClose(state, setState)} | ||
| onClose={ev => handleClose(state, setState)(ev, 'click')} |
There was a problem hiding this comment.
why click? if it's an arbitrary value it can also be undefined or null
There was a problem hiding this comment.
yes, because we use "clickaway" and "timeout", I think "click" is also explicit
|
🎉 This PR is included in version 130.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to disable closing when clicking away or waiting the timeout. I moved the handleClose func in a helper file to avoid styleguide messing with func name