Thanks to visit codestin.com
Credit goes to github.com

Skip to content

format codes & fix format shortcut & update QCodeEditor #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 3, 2020
Merged

format codes & fix format shortcut & update QCodeEditor #67

merged 3 commits into from
Jan 3, 2020

Conversation

@ouuan
Copy link
Member

@ouuan ouuan commented Jan 2, 2020

No description provided.

@ghost
Copy link

ghost commented Jan 2, 2020

Hi ouuan
Thank you for your contribution to cp-editor2. I will request a review from one of the contributor. Once they approves and all CI checks passes, I will merge your Pull Request.

@ghost ghost requested a review from coder3101 January 2, 2020 14:14
@ouuan ouuan changed the title format codes & fix format shortcut format codes & fix format shortcut & update QCodeEditor Jan 2, 2020
@coder3101
Copy link
Member

coder3101 commented Jan 2, 2020

I assume this code format is done by .clangformat in source root?

@ouuan
Copy link
Member Author

ouuan commented Jan 2, 2020

I assume this code format is done by .clangformat in source root?

I think so. Visual Studio said it used .clangformat in source root automatically.

@ouuan
Copy link
Member Author

ouuan commented Jan 2, 2020 •
edited
Loading

Maybe the QCodeEditor commit should be separated? I added it together with formatting carelessly.

@ghost ghost added the ready_to_merge label Jan 2, 2020
@ouuan
Copy link
Member Author

ouuan commented Jan 2, 2020

But I have to go to the dormitory now :(

@coder3101
Copy link
Member

coder3101 commented Jan 2, 2020

You don't need to change QCodeEditor files in PR. Instead you should update it locally with git submodule update command. I will not merge it now, you need to remove that QCodeEditor file from this PR rest is Okay. Take your time, soon i will publish the new blog about this editor. Meanwhile you could try it and so this is why it's in beta.

@coder3101 coder3101 self-requested a review January 2, 2020 14:30
coder3101
coder3101 requested changes Jan 2, 2020
View reviewed changes
Copy link
Member

@coder3101 coder3101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR Must not include QCodeEditor files.

@ghost
Copy link

ghost commented Jan 2, 2020

@ouuan , Reviewer has requested changes to your Pull request. I will again ask a reviewer to review it after you update this PR by pushing to PR originating branch

@ghost ghost added the change_requested label Jan 2, 2020
@ghost ghost removed the change_requested label Jan 3, 2020
@ghost ghost requested a review from coder3101 January 3, 2020 05:04
@ghost
Copy link

ghost commented Jan 3, 2020

Thank you for the changes. I have re-requested the review

@ouuan
Copy link
Member Author

ouuan commented Jan 3, 2020

BTW, what's the problem with the system-wide dark theme? (I don't know where to ask this question, so ask here.)

@ghost ghost added the ready_to_merge label Jan 3, 2020
@coder3101
Copy link
Member

coder3101 commented Jan 3, 2020

BTW, what's the problem with the system-wide dark theme? (I don't know where to ask this question, so ask here.)

Qt does not support Dark theme, the current theme is nothing but a Qt implementation of KDE that has dark theme. In KDE Plasma and other distro that mix well with Qt, you can turn on system theme Dark and it manages and changes the theme to dark. I will however look into if there is a way out.

@coder3101 coder3101 merged commit ed3d18a into cpeditor:master Jan 3, 2020
@coder3101
Copy link
Member

coder3101 commented Jan 3, 2020

Hey, if you get some time could you also re-write(modify) the README to match the new Editor features?

@ouuan ouuan deleted the patch-1 branch January 3, 2020 08:41
@ouuan
Copy link
Member Author

ouuan commented Jan 8, 2020

BTW, what's the problem with the system-wide dark theme? (I don't know where to ask this question, so ask here.)

Qt does not support Dark theme, the current theme is nothing but a Qt implementation of KDE that has dark theme. In KDE Plasma and other distro that mix well with Qt, you can turn on system theme Dark and it manages and changes the theme to dark. I will however look into if there is a way out.

I mean, what are the "serious UI/UX issues", and why was it available in old versions but not in the current version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coder3101 coder3101 coder3101 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ouuan @coder3101