Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ouuan
Copy link
Member

@ouuan ouuan commented Jan 9, 2020

I think the editing part is done, maybe needs some testing.

I'll add the "use snippets in the code editor" part tomorrow. Though it should be easy to implement, I don't have time today.

@ghost
Copy link

ghost commented Jan 9, 2020

Hi ouuan
Thank you for your contribution to cp-editor. I will request a review from one of the contributor. Once they approves and all CI checks passes, I will merge your Pull Request.

@ghost ghost requested a review from coder3101 January 9, 2020 14:16
@coder3101
Copy link
Member

My work on CF tools to submit is almost done and no more big code changes will be required. Here is what i would like to also let you know, add snippets for all 3 language and it will be better if they are all 3 in different files. Maybe json files for each language snippets.

@coder3101
Copy link
Member

I just reviewed your code and it looks good. You can ignore that json to store snippets, .ini will be good to. All Editor related things in one place, i also see you implementing different languages snippets separately depending upto tab language. That is good as expected. Take your time and perfect this feature. Also Thanks for your valuable work in CP editor.

@coder3101 coder3101 added the work in progress The work has been started and is in progress. label Jan 10, 2020
@ouuan ouuan marked this pull request as ready for review January 10, 2020 08:35
@coder3101
Copy link
Member

So i am merging this to master now. Also my work on cf-tools is ready as well. You could try now.

@coder3101 coder3101 merged commit 77151c4 into cpeditor:master Jan 10, 2020
@coder3101 coder3101 removed the work in progress The work has been started and is in progress. label Jan 10, 2020
@coder3101 coder3101 removed their request for review January 10, 2020 10:30
@ouuan ouuan deleted the snippets branch January 10, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants