Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ouuan
Copy link
Member

@ouuan ouuan commented Jan 12, 2020

No description provided.

@ghost
Copy link

ghost commented Jan 12, 2020

Hi ouuan
Thank you for your contribution to cp-editor. I will request a review from one of the contributor. Once they approves and all CI checks passes, I will merge your Pull Request.

@ghost ghost requested a review from coder3101 January 12, 2020 12:10
@ouuan
Copy link
Member Author

ouuan commented Jan 12, 2020

image

Oops, the editor can't be expanded vertically.

@ouuan
Copy link
Member Author

ouuan commented Jan 12, 2020

image

What's this used for?

@coder3101
Copy link
Member

It is a spacer, adds space between widget. Vertical space

@ouuan
Copy link
Member Author

ouuan commented Jan 12, 2020

It is a spacer, adds space between widget. Vertical space

Why do you use it?

@coder3101
Copy link
Member

coder3101 commented Jan 12, 2020 via email

@ouuan
Copy link
Member Author

ouuan commented Jan 12, 2020

To add spacing for better looks, you can remove it if you find it not okay, i am neutral on this.

On Sun, 12 Jan, 2020, 6:20 pm ouuan, @.***> wrote: It is a spacer, adds space between widget. Vertical space Why do you use it? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#95?email_source=notifications&email_token=AFJO5I2O5WBVUE45T62PRZ3Q5MGX3A5CNFSM4KFXKYUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWZHGI#issuecomment-573412249>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFJO5I3SJYJGFJMDZ25WEDLQ5MGX3ANCNFSM4KFXKYUA .

How to make the editor expandable with the spacer?

@ghost ghost added the ready_to_merge label Jan 13, 2020
@coder3101 coder3101 merged commit ca66c50 into cpeditor:master Jan 13, 2020
@ouuan ouuan deleted the snippets branch January 13, 2020 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants