feat: make file logic like Sublime #97
Conversation
|
Hi ouuan |
1. Open file when necessary instead of holding it. 2. Watch file changes on disk. 3. Show complete path when multiple tabs are of the same name. 4. Change language when saving unsaved files / saving as. 5. Text changes and other minor changes.
4fb7832 to
1c11ed0
Compare
|
Yes you are right, when i started the project i was not very aware of Qt API like QTemporaryFile. But Since now you have discovered it, it surely is nice to get rid of Base::Files because they can in future become a bottleneck and are not very portable. Let's Qt handle all cross platform things. |
|
I guess this is work in progress. So I will review it once you ask me to do so. |
I can also make a new PR and merge this to it, or work on #82 in this PR. But for a clean commit history, I'd like to have this PR merged first. |
bd03a31 to
84d85c2
Compare
This reverts commit 266e236.
Open file when necessary instead of holding it.
Watch file changes on disk.
Show complete path when multiple tabs are of the same name.
Change language when saving unsaved files / saving as.
Text changes and other minor changes.
Please test these changes. I think there might be some bugs, especially when handling read/write file fails, and things related to problemURL.