Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ENH] update config #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 22, 2023
Merged

[ENH] update config #126

merged 14 commits into from
Jan 22, 2023

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Jan 21, 2023 •
edited
Loading

closes #123

  • only keep the default model in the docher file
  • add Source info in json file
  • enable using reset_database

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 21, 2023 •
edited
Loading

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.24%.

Quality metrics Before After Change
Complexity 3.37 ⭐ 3.13 ⭐ -0.24 👍
Method Length 77.72 🙂 78.96 🙂 1.24 👎
Working memory 6.69 🙂 6.71 🙂 0.02 👎
Quality 74.04% 🙂 74.28% 🙂 0.24% 👍
Other metrics Before After Change
Lines 1125 1186 61
Changed files Quality Before Quality After Quality Change
bidsmreye/bids_utils.py 75.38% ⭐ 74.98% 🙂 -0.40% 👎
bidsmreye/bidsmreye.py 62.40% 🙂 61.25% 🙂 -1.15% 👎
bidsmreye/configuration.py 67.42% 🙂 69.28% 🙂 1.86% 👍
bidsmreye/prepare_data.py 72.73% 🙂 69.37% 🙂 -3.36% 👎
tests/test_bids_utils.py 90.87% ⭐ 89.55% ⭐ -1.32% 👎
tests/test_utils.py 90.56% ⭐ 90.51% ⭐ -0.05% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
bidsmreye/bidsmreye.py bidsmreye 10 🙂 202 😞 21 ⛔ 35.69% 😞 Try splitting into smaller methods. Extract out complex expressions
bidsmreye/configuration.py Config.check_argument 11 🙂 178 😞 9 🙂 51.65% 🙂 Try splitting into smaller methods
bidsmreye/bids_utils.py check_layout 9 🙂 151 😞 9 🙂 56.09% 🙂 Try splitting into smaller methods
bidsmreye/configuration.py Config.__attrs_post_init__ 7 ⭐ 194 😞 7 🙂 58.59% 🙂 Try splitting into smaller methods
bidsmreye/bidsmreye.py dispatch 11 🙂 89 🙂 10 😞 59.93% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Remi-Gau Remi-Gau merged commit a0df711 into cpp-lln-lab:main Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

use circle ci to test system of the docker image

1 participant

@Remi-Gau