Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[REF] use Path instead of os.path #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 23, 2022
Merged

[REF] use Path instead of os.path #31

merged 5 commits into from
Jul 23, 2022

Conversation

@Remi-Gau
Copy link
Contributor

closes #24

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 23, 2022 •
edited
Loading

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.16%.

Quality metrics Before After Change
Complexity 2.29 ⭐ 2.42 ⭐ 0.13 👎
Method Length 49.83 ⭐ 51.14 ⭐ 1.31 👎
Working memory 7.64 🙂 7.90 🙂 0.26 👎
Quality 75.20% ⭐ 74.04% 🙂 -1.16% 👎
Other metrics Before After Change
Lines 1097 1149 52
Changed files Quality Before Quality After Quality Change
bidsmreye/bidsutils.py 81.78% ⭐ 81.12% ⭐ -0.66% 👎
bidsmreye/combine.py 66.79% 🙂 66.96% 🙂 0.17% 👍
bidsmreye/generalize.py 52.60% 🙂 52.29% 🙂 -0.31% 👎
bidsmreye/prepare_data.py 71.60% 🙂 71.60% 🙂 0.00%
bidsmreye/run.py 51.59% 🙂 51.64% 🙂 0.05% 👍
bidsmreye/utils.py 86.13% ⭐ 82.89% ⭐ -3.24% 👎
docs/source/conf.py 79.57% ⭐ 79.97% ⭐ 0.40% 👍
tests/test_bidsutils.py 93.62% ⭐ 92.52% ⭐ -1.10% 👎
tests/test_combine.py 94.06% ⭐ 94.71% ⭐ 0.65% 👍
tests/test_generalize.py 87.18% ⭐ 87.81% ⭐ 0.63% 👍
tests/test_utils.py 88.75% ⭐ 87.41% ⭐ -1.34% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
bidsmreye/generalize.py generalize 3 ⭐ 225 ⛔ 17 ⛔ 43.71% 😞 Try splitting into smaller methods. Extract out complex expressions
bidsmreye/run.py main 11 🙂 250 ⛔ 8 🙂 48.93% 😞 Try splitting into smaller methods
bidsmreye/combine.py process_subject 3 ⭐ 168 😞 15 😞 50.25% 🙂 Try splitting into smaller methods. Extract out complex expressions
bidsmreye/bidsutils.py check_layout 3 ⭐ 90 🙂 13 😞 62.21% 🙂 Extract out complex expressions
bidsmreye/prepare_data.py preprocess_subject 1 ⭐ 93 🙂 13 😞 63.78% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Remi-Gau Remi-Gau merged commit 90556eb into main Jul 23, 2022
@Remi-Gau Remi-Gau deleted the path branch July 23, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

use Path module instead of os.path

2 participants

@Remi-Gau