GO_LDFLAGS and git metadata - Fedora specific questions #8989

buckaroogeek · 2025-02-04T23:30:41Z

buckaroogeek
Feb 4, 2025

The legacy rpm spec file used to build cri-o includes the following export which sets the value of certain fields at build-time.

export BASE_LDFLAGS="-X %{goipath}/internal/pkg/criocli.DefaultsPath=%{criocli_path}
-X  %{goipath}/internal/version.buildDate=%{build_timestamp}
-X  %{goipath}/internal/version.gitCommit=%{commit0}
-X  %{goipath}/internal/version.version=%{version}
-X  %{goipath}/internal/version.gitTreeState=%{git_tree_state} "

As far as I can tell from current CRI-O code, only buildDate can now be set. Everything else in the above GO_LDFLAGS string is ignored. Am I following the code correctly?

The build-time LDFLAGS is stored and available via crio -v when a fedora built CRI-O package is installed but git related metadata cannot be set via LDFLAGS as far as I can tell. Is that accurate?

thanks

Answered by saschagrunert

Feb 5, 2025

Hey @buckaroogeek, yes, that's correct 👍

cri-o/internal/version/version.go

Lines 29 to 32 in 6601c98

     // Variables injected during build-time.  
   var (  
   buildDate string // build date in ISO8601 format, output of $(date -u +'%Y-%m-%dT%H:%M:%SZ')  
   )  

 

The dynamic stuff happens there:

cri-o/internal/version/version.go

Lines 151 to 155 in 6601c98

     func Get(verbose bool) (*Info, error) {  
   info, ok := debug.ReadBuildInfo()  
   if !ok {  
   return nil, errors.New("unable to retrieve build info")  
   }  

 

View full answer

saschagrunert · 2025-02-05T08:04:53Z

saschagrunert
Feb 5, 2025
Maintainer

Hey @buckaroogeek, yes, that's correct 👍

cri-o/internal/version/version.go

Lines 29 to 32 in 6601c98

    
           // Variables injected during build-time. 
        
           var ( 
        
           	buildDate string // build date in ISO8601 format, output of $(date -u +'%Y-%m-%dT%H:%M:%SZ') 
        
           )

The dynamic stuff happens there:

cri-o/internal/version/version.go

Lines 151 to 155 in 6601c98

    
           func Get(verbose bool) (*Info, error) { 
        
           	info, ok := debug.ReadBuildInfo() 
        
           	if !ok { 
        
           		return nil, errors.New("unable to retrieve build info") 
        
           	}

1 reply

buckaroogeek Feb 5, 2025
Author

Excellent! Many thanks for the prompt and informative response.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GO_LDFLAGS and git metadata - Fedora specific questions #8989

Uh oh!

{{title}}

Uh oh!

Replies: 1 comment 1 reply

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

	// Variables injected during build-time.
	var (
	buildDate string // build date in ISO8601 format, output of $(date -u +'%Y-%m-%dT%H:%M:%SZ')
	)

	func Get(verbose bool) (*Info, error) {
	info, ok := debug.ReadBuildInfo()
	if !ok {
	return nil, errors.New("unable to retrieve build info")
	}

GO_LDFLAGS and git metadata - Fedora specific questions #8989

Uh oh!

buckaroogeek Feb 4, 2025

Replies: 1 comment · 1 reply

Uh oh!

saschagrunert Feb 5, 2025 Maintainer

Uh oh!

buckaroogeek Feb 5, 2025 Author

buckaroogeek
Feb 4, 2025

Replies: 1 comment 1 reply

saschagrunert
Feb 5, 2025
Maintainer

buckaroogeek Feb 5, 2025
Author