-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.
Description
Currently, calling crio config spits out an entire config file. However, it would be prudent for us to move away from the monolithic config file, in favor of smart defaults, and drop-in files.
However, to do this, there needs to be a way for users to quickly create drop-in files, and have them not override the defaults where they don't need to.
The main advantage to this approach is it allows us to change defaults without as much churn in config files.
This proposal is to change crio config to render the configuration/flags it's passed, and only print the toml for the fields that are different than the default.
Sample could be:
crio --log-level debug config
would only output
[crio]
[crio.runtime]
log_level = "debug"
/kind feature
Metadata
Metadata
Assignees
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.