From 5a6411413cd7f43ef1fbc3579360f5ccf6f95f05 Mon Sep 17 00:00:00 2001 From: Sascha Grunert Date: Mon, 30 Aug 2021 09:40:21 +0200 Subject: [PATCH] Fix missing quantile in `latency_microseconds_total` metrics The quantile has to be added manually since a couple of prometheus client releases and we missed that. Adding an integration test to ensure that the quantile exist in the future. Signed-off-by: Sascha Grunert --- server/metrics/metrics.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/server/metrics/metrics.go b/server/metrics/metrics.go index 3d5f6541ada..8a345d33b8b 100644 --- a/server/metrics/metrics.go +++ b/server/metrics/metrics.go @@ -56,9 +56,10 @@ var ( // type. CRIOOperationsLatencyTotal = prometheus.NewSummaryVec( prometheus.SummaryOpts{ - Subsystem: subsystem, - Name: CRIOOperationsLatencyTotalKey, - Help: "Latency in microseconds of CRI-O operations. Broken down by operation type.", + Subsystem: subsystem, + Name: CRIOOperationsLatencyTotalKey, + Help: "Latency in microseconds of CRI-O operations. Broken down by operation type.", + Objectives: map[float64]float64{0.5: 0.05, 0.9: 0.01, 0.99: 0.001}, }, []string{"operation_type"}, )