fix: use tinygo reactor module #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
After this is merged, i will also update the go-pdk docs to mention this |
bhelx
reviewed
Dec 19, 2024
| tinygo_version=$(tinygo version | grep -o '[0-9]\+\.[0-9]\+\.[0-9]\+' | head -n1) | ||
| if ! version_gt "$tinygo_version" "0.34.0"; then | ||
| missing_deps=1 | ||
| echo "❌ TinyGo version must be greater than 0.34.0 (current version: $tinygo_version)" |
bhelx
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since TinyGo now officially supports reactor modules, we should switch to it:
tinygo-org/tinygo#4451
This make sure xtp plugins can use wasi features out of the box without resorting to hacks, the only downside is that we have to force people to upgrade to TinyGo version 0.34.0