Thanks to visit codestin.com
Credit goes to github.com

Skip to content

skipIfSuccessful skips too much #799

@fbartels

Description

@fbartels

Reading the documentation at https://dagu.readthedocs.io/en/latest/yaml_format.html#skip-redundant-runs the option should "check[s] if there’s already been a successful run since the last scheduled time. If yes, it skips the execution", but this does not seem to be the case.

I have a dag that has these attributes:

schedule: "0 * * * *"
skipIfSuccessful: true

So from the description it should run every hour and if it has been manually executed in between, would skip the next hourly run. But looking at the logs this rather seems to cause the dag to only every run every second hour.

I have not inspected the code, but could it be that skipIfSuccessful matches on the completion time of a dag and not its starting time?

Using v1.16.0, but I also made the observation with v1.15.0.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions