Feat add baggage support #8649
Merged
Feat add baggage support #8649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
…rflow CI Signed-off-by: Cassandra Coyle <[email protected]>
Contributor
|
Someone at Kubecon was asking me if |
Contributor
Author
|
I have on a TODO to do documentation updates, that wont be forgotten :) -- edited: docs are done. see PR here |
This was referenced Apr 8, 2025
Closed
Signed-off-by: Cassandra Coyle <[email protected]>
This was referenced Apr 9, 2025
Contributor
Author
|
Ill fix CI |
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
cicoyle
commented
Apr 17, 2025
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Contributor
Author
|
Will fix lint - this PR is ready for review still! Its not related to the baggage logic |
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
JoshVanL
requested changes
Apr 24, 2025
tests/integration/suite/daprd/tracing/serviceinvocation/serviceinvocation.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added baggage support through both context propagation (aligning with OpenTelemetry) & header propagation (maintaining consistency with Dapr's existing tracing headers). For security, context and header baggage are strictly separated and never merged between domains. HTTP header baggage maintains URL encoding (e.g.,
%20for spaces,%2Ffor slashes) to ensure safe transmission of special characters in HTTP headers, while context baggage uses decoded values as per OpenTelemetry's conventions. Clean up some consts along the way. Needs this http binding components contrib PR for the http binding IT test..docs PR for this work
Relates to this issue