This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Resolve a number of open issues #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
previously requested changes
Feb 26, 2017
|
|
||
| /// Lazily builds a [PartDirective] AST when built. | ||
| class PartBuilder extends Object | ||
| with HasAnnotationsMixin |
Contributor
There was a problem hiding this comment.
[optional] could be class PartBuilder extends HasAnnotationsMixin
Contributor
Author
There was a problem hiding this comment.
Acknowledged. I like keeping it like this to ensure it stays mixin compatible.
lib/src/builders/reference.dart
Outdated
| ReferenceBuilder._(this._name, [this._importFrom]); | ||
|
|
||
| /// Name of the reference. | ||
| String get name => _name; |
Contributor
There was a problem hiding this comment.
Make the field public instead, it is already final
lib/src/builders/method.dart
Outdated
| _RedirectingConstructorBuilder( | ||
| this.name, | ||
| this.redirectToClass, { | ||
| this.asConst, |
Contributor
There was a problem hiding this comment.
This should probably have a default value, it's read without a null check.
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
* Add new features. * More changes. * Dartfmt. * Yegors issue. * Address feedback and merge. * Oops.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.0.0-beta+4
PartBuildertoPartOfBuilder.PartBuilder, to representpart '...dart'directives.HasAnnotationsinterface to all library/part/directive builders.asFactoryandasConsttoConstructorBuilder.ConstructorBuilder.redirectTofor a redirecting factory constructor.namegetter toReferenceBuilder.'') is equivalent tonull(default).Closes dart-lang/tools#912
Closes dart-lang/tools#910
Closes dart-lang/tools#907
Partially addresses dart-lang/tools#966