Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add end to end test for package:watcher. #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2025
Merged

Add end to end test for package:watcher. #2227

merged 1 commit into from
Nov 7, 2025
+448 −0

Conversation

@davidmorgan
Copy link
Contributor

@davidmorgan davidmorgan commented Oct 28, 2025 •
edited
Loading

Add a new type of test coverage.

Watch a directory, then make lots of random changes in the directory, updating state based on events from the watcher.

Then see if the state matches what's actually on the filesystem.

This found the Linux directory move issue #2228, ignore the failure on Linux for that. It's reliable and always on the same file, example failure. So we can actually assert that it fails.

  Failed on run 2.
  Files changes: /tmp/DMKWAX/changes.txt
  Client log: /tmp/DMKWAX/client.txt
  package:matcher                                    fail
  test/directory_watcher/end_to_end_tests.dart 66:9  endToEndTests.<fn>
  
Failed, tracked but not on disk:

/tmp/XACZOK/g/c/65588

Failed, tracking is out of date:

/tmp/XACZOK/e/e/c/65588 tracked=16 actual=516

This also found the Windows directory race issue #2234, ignore the failure on Windows for that, example failure. It doesn't reliably fail, so we can't assert either way.

  Failed on run 0.
  Files changes: C:\Users\davidmorgan\AppData\Local\Temp\48f9caf3\changes.txt
  Client log: C:\Users\davidmorgan\AppData\Local\Temp\48f9caf3\client.txt
  package:matcher                                    fail
  test\directory_watcher\end_to_end_tests.dart 66:9  endToEndTests.<fn>

Failed, tracking is out of date:

C:\Users\davidmorgan\AppData\Local\Temp\8783da29\a\d\49883 tracked=708 actual=972

@github-actions
Copy link

github-actions bot commented Oct 28, 2025 •
edited
Loading

Package publishing

Package Version Status Publish tag (post-merge)
package:bazel_worker 1.1.4 already published at pub.dev
package:benchmark_harness 2.4.0-wip WIP (no publish necessary)
package:boolean_selector 2.1.2 already published at pub.dev
package:browser_launcher 1.1.3 already published at pub.dev
package:cli_config 0.2.1-wip WIP (no publish necessary)
package:cli_util 0.5.0-wip WIP (no publish necessary)
package:clock 1.1.3-wip WIP (no publish necessary)
package:code_builder 4.11.0 already published at pub.dev
package:coverage 1.15.0 already published at pub.dev
package:csslib 1.0.2 already published at pub.dev
package:extension_discovery 2.1.0 already published at pub.dev
package:file 7.0.2-wip WIP (no publish necessary)
package:file_testing 3.1.0-wip WIP (no publish necessary)
package:glob 2.1.3 already published at pub.dev
package:graphs 2.3.3-wip WIP (no publish necessary)
package:html 0.15.7-wip WIP (no publish necessary)
package:io 1.1.0-wip WIP (no publish necessary)
package:json_rpc_2 4.0.0 already published at pub.dev
package:markdown 7.3.1-wip WIP (no publish necessary)
package:mime 2.1.0-wip WIP (no publish necessary)
package:oauth2 2.0.5 already published at pub.dev
package:package_config 2.3.0-wip WIP (no publish necessary)
package:pool 1.5.2 already published at pub.dev
package:process 5.0.5 already published at pub.dev
package:pub_semver 2.2.0 already published at pub.dev
package:pubspec_parse 1.5.1-wip WIP (no publish necessary)
package:source_map_stack_trace 2.1.3-wip WIP (no publish necessary)
package:source_maps 0.10.14-wip WIP (no publish necessary)
package:source_span 1.10.1 already published at pub.dev
package:sse 4.1.8 already published at pub.dev
package:stack_trace 1.12.2-wip (error) pubspec version (1.12.2-wip) and changelog (1.12.2-dev) don't agree
package:stream_channel 2.1.4 already published at pub.dev
package:stream_transform 2.1.2-wip WIP (no publish necessary)
package:string_scanner 1.4.1 already published at pub.dev
package:term_glyph 1.2.3-wip WIP (no publish necessary)
package:test_reflective_loader 0.5.0 ready to publish test_reflective_loader-v0.5.0
package:timing 1.0.2 already published at pub.dev
package:unified_analytics 8.0.8 ready to publish unified_analytics-v8.0.8
package:watcher 1.1.5-wip WIP (no publish necessary)
package:yaml 3.1.3 already published at pub.dev
package:yaml_edit 2.2.2 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions
Copy link

github-actions bot commented Oct 28, 2025 •
edited
Loading

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
watcher None 1.1.4 1.1.5-wip 1.1.4 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️ 
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/coverage/lib/src/coverage_options.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart
pkgs/html/test/trie_test.dart
pkgs/html/tool/generate_trie.dart
pkgs/pubspec_parse/test/git_uri_test.dart
pkgs/stack_trace/example/example.dart
pkgs/watcher/test/custom_watcher_factory_test.dart
pkgs/yaml_edit/example/example.dart

This check can be disabled by tagging the PR with skip-license-check.

@davidmorgan davidmorgan force-pushed the watcher-e2e branch 5 times, most recently from 38330a9 to 9a822f3 Compare November 4, 2025 10:41
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Nov 4, 2025
@github-actions github-actions bot removed the type-infra A repository infrastructure change or enhancement label Nov 4, 2025
@davidmorgan davidmorgan force-pushed the watcher-e2e branch 8 times, most recently from ea47e6c to 742b8d8 Compare November 5, 2025 16:18
@davidmorgan davidmorgan marked this pull request as ready for review November 5, 2025 16:40
@davidmorgan davidmorgan requested a review from a team as a code owner November 5, 2025 16:40
@davidmorgan davidmorgan mentioned this pull request Nov 6, 2025
Merged
@davidmorgan davidmorgan merged commit c423dbe into dart-lang:main Nov 7, 2025
18 checks passed
@davidmorgan davidmorgan deleted the watcher-e2e branch November 7, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chloestefantsova chloestefantsova chloestefantsova approved these changes

Assignees

No one assigned

Labels

package:watcher

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidmorgan @chloestefantsova