Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

studio: assets (are already) private #585

@peterpeterparker

Description

@peterpeterparker

Affected part of DeckDeckGo

  • [X ] Studio

Feature Description

Users are editing their presentations privately but currently, when they upload assets (images or charts data), these are made public because the Firebase Storage rules makes the storage content public to everyone (only read).

Users are informed about this through a popup (see screenshot).

That's the current status but it's about to change :)

Goal of this feature is to make the presentations assets (images and data), which would be saved in the Firebase Storage, private too until the presentation is shared online ("published") respectively until the presentation becomes public.

Screenshot

Capture d’écran 2020-01-13 à 20 41 24

Limitation

Google Firebase Storage is a bit tricky when it comes to having files private and on demand becoming public. One approach was described on Stackoverflow but will have, depending of the amount of assets, some impact on the performances.

Therefore we will also add a delay between the publication and listing of the presentation on the "feed" mask.

UPDATE AND FINAL RESULTS

Actually assets are already private. This stackoverflow answer the question.

Basically: yes all Google Storage files are exposed (read) on internet through a download URL but it contains a token which is almost impossible to guess, therefore, as long as rules are correctly set to read and write the data directly (without download url), then files could be considered as private.

Metadata

Metadata

Labels

enhancementNew feature or requeststudio"Studio" is the codename for the web editor

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions