os: implement tempDirSync and use in tests.ts #100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ry
approved these changes
Jun 4, 2018
starkwang
reviewed
Jun 5, 2018
os.ts
Outdated
| const res = sendMsg("os", { | ||
| command: pb.Msg.Command.TEMP_DIR_SYNC, | ||
| tempDirSyncDirname: dir, | ||
| temoDirSyncPrefix: prefix |
There was a problem hiding this comment.
typo: temoDirSyncPrefix -> tempDirSyncPrefix
starkwang
reviewed
Jun 5, 2018
msg.proto
Outdated
|
|
||
| // TEMP_DIR_SYNC | ||
| string temp_dir_sync_dirname = 140; | ||
| string temo_dir_sync_prefix = 141; |
os.go
Outdated
| return WriteFileSync(msg.WriteFileSyncFilename, msg.WriteFileSyncData, | ||
| msg.WriteFileSyncPerm) | ||
| case Msg_TEMP_DIR_SYNC: | ||
| return TempDirSync(msg.TempDirSyncDirname, msg.TemoDirSyncPrefix) |
There was a problem hiding this comment.
...My faults. Thank you so much :-)
|
@ry Sorry, I accidentally closed this PR, can you reopen it? |
piscisaureus
pushed a commit
to piscisaureus/deno
that referenced
this pull request
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cholerae Hu [email protected]