fix(lsp): lsp should respect include/exclude files in format config #12876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Nov 23, 2021
dsherret
commented
Nov 24, 2021
cli/main.rs
Outdated
| specifier_to_file_path(&config_file.specifier) | ||
| .ok() | ||
| .map(|p| p.to_str().map(|s| s.to_string())) | ||
| .flatten() |
Member
Author
There was a problem hiding this comment.
It seems like it would be better to just do config_file.specifier.to_string() here? I didn't want to introduce a breaking change on this key though. Thoughts?
Edit: If we ever introduced remote configs then we would need to change this to just use the specifier.
Member
There was a problem hiding this comment.
That change seems reasonable 👍
fbb16b5 to
1eaf50a
Compare
piscisaureus
pushed a commit
that referenced
this pull request
Nov 24, 2021
piscisaureus
pushed a commit
to piscisaureus/deno
that referenced
this pull request
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes it so the LSP sticks with module specifiers in the config file. I ran into an issue on CI with Mac where it was canonicalizing the file path of the config file and causing issues because now the config file was at a "different place" relative to potentially open files that aren't necessarily on the file system.
Closes #12865
Closes #12877