Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add better ksh support #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2019
Merged

Add better ksh support #2245

merged 2 commits into from
Jan 26, 2019

Conversation

@andrewimeson
Copy link
Contributor

Ksh was not being detected properly for me by ALE

A file with this code would be run by ALE through /bin/sh -n and by shellcheck with -s sh, leading to it incorrectly complaining about process substitution being undefined in POSIX sh.

#!/bin/ksh

diff -w <(find expected_logs/ -maxdepth 1 | sed 's/.expected//' | sort) <(find logs/ -maxdepth 1 | sed -E 's/\.[^.]+\.log$//' | sort)

I tested it locally and it fixes my issue.

@w0rp w0rp merged commit 0a9dc7b into dense-analysis:master Jan 26, 2019
@w0rp
Copy link
Member

w0rp commented Jan 26, 2019

Cheers! 🍻

@andrewimeson andrewimeson deleted the adi/add-ksh-support branch February 12, 2019 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@w0rp w0rp w0rp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewimeson @w0rp