Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bench Stop key binding shadows vim key navigation #505

@andrewbenton

Description

@andrewbenton




Describe the bug
On some screens, such as the services pane, the Bench Stop action is registered against the k key. This shadows the vim key (j, k) navigation that's present throughout the rest of the UI. Shadowing these keys anywhere can lead to users accidentally invoking commands when trying to navigate.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the services pane
  2. Scroll down by hitting j.
  3. Attempt to scroll up by hitting k.

Expected behavior
I expect that vim key navigation will never be shadowed throughout the application in the same way that I expect that arrow keys should always work for navigation.

Screenshots
Screenshot from 2020-01-22 02-36-42

Versions (please complete the following information):

  • OS: linux
  • K9s at least 0.12.0, but also in 0.13.2
  • K8s n/a

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions