Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Design Language Properties Not Compiling when Deeper Than First Level #139

@phil-lgr

Description

@phil-lgr

Steps to reproduce

git clone [email protected]:diez/diez.git
cd diez
yarn
cd examples/lorem-ipsum/design-language/
yarn
yarn demo

Then change lines 39-... to this:

const typography = {
   // put heading1 under a normal prop
    nested: {
        heading1: new Typograph({
            font: Fonts.SourceSansPro.Regular,
            fontSize: 24,
            color: palette.text,
        }),
    },

  body: new Typograph({
    font: Fonts.SourceSansPro.Regular,
    fontSize: 18,
    color: palette.text,
    alignment: TextAlignment.Center,
  }),

  caption: new Typograph({
    font: Fonts.SourceSansPro.Regular,
    fontSize: 14,
    color: palette.caption,
  }),
}

Expected behavior:

heading1 typograph outputs under nested

Actual behavior: heading1 is not outputted

class Typography {
  constructor({
    body = {font: {file: {src: "assets/SourceSansPro-Regular.ttf", type: "font"}, name: "SourceSansPro-Regular", fallbacks: ["sans-serif"], weight: 400, style: "normal"}, fontSize: 18, color: {h: 0.6666666666666666, s: 1, l: 0.03137254901960784, a: 1}, lineHeight: -1, letterSpacing: 0, alignment: "center", decoration: []},
    caption = {font: {file: {src: "assets/SourceSansPro-Regular.ttf", type: "font"}, name: "SourceSansPro-Regular", fallbacks: ["sans-serif"], weight: 400, style: "normal"}, fontSize: 14, color: {h: 0.7085385878489326, s: 0.8565400843881857, l: 0.5352941176470588, a: 1}, lineHeight: -1, letterSpacing: 0, alignment: "natural", decoration: []}
  } = {}) {

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions