fix grammar on timezone specific docs sections #3044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sh-rp
commented
Sep 1, 2025
| Ultimately destination will interpret the timestamp values. Some destinations: | ||
| - do not support naive timestamps (ie. BigQuery) and will interpret them as naive UTC by attaching UTC timezone | ||
| - do not support tz-aware timestamps (ie. Dremio, Athena) and will strip timezones from timestamps being loaded | ||
| Ultimately, the destination will interpret the timestamp values. Some destinations: |
There was a problem hiding this comment.
These destination specific things should be on the destination docs page. I have had the idea of generating a section on each destination page from the most important parts of the Capabilities so it gets maintained automatically. But maybe this is overkill.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This quick PR fixes the grammar on the docs sections of the recent timezone PR.