Undefining a module no longer undefines special modules, issue #128 #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
==========================================
+ Coverage 85.58% 85.63% +0.05%
==========================================
Files 1 1
Lines 548 550 +2
Branches 136 137 +1
==========================================
+ Hits 469 471 +2
Misses 32 32
Partials 47 47
Continue to review full report at Codecov.
|
kitsonk
approved these changes
Apr 28, 2017
|
Yeah I thought about that. I'm not sure where the line is on how much we should be protect people from doing something ... questionable. |
|
Yeah, I guess this meets the scope of the issue and we shouldn't allow me to scope creep us! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
Fix for undefining modules that have dependencies on
require,exports, ormodule. These special modules should never be undefined!Resolves #128