fix: display the invalid semver range as part of the error

dominykas · dominykas · commit 04c92ba8d93c · 2019-03-14T10:21:38.000+02:00
diff --git a/lib/index.js b/lib/index.js
@@ -135,8 +135,7 @@ exports.run = async (options) => {
     packagesWithScripts
         .forEach((entry) => {
 
-            const path = entry.path;
-            const childPkg = entry.childPkg;
+            const { path, childPkg } = entry;
             const name = entry.childPkg.name;
 
             if (allowScripts[name] === undefined) {
@@ -155,7 +154,7 @@ exports.run = async (options) => {
             }
 
             if (!Semver.validRange(allowScripts[name])) {
-                errors.push(`${name} (invalid semver range)`);
+                errors.push(`${name} (invalid semver range: ${allowScripts[name]})`);
                 return;
             }
 
diff --git a/test/index.js b/test/index.js
@@ -190,7 +190,7 @@ describe('allow-scripts', () => {
                 'without-scripts'
             ]);
 
-            await expect(Allow.run({})).to.reject('Mis-configured allowedScripts: @example/with-install-script (invalid semver range)');
+            await expect(Allow.run({})).to.reject('Mis-configured allowedScripts: @example/with-install-script (invalid semver range: not-a-semver-range)');
 
             expect(fixture.getActualResult()).to.equal('');
             expect(fixture.getLog()).to.equal('');

Original file line number	Diff line number	Diff line change
`@@ -135,8 +135,7 @@ exports.run = async (options) => {`
`135`	`135`	`packagesWithScripts`
`136`	`136`	`.forEach((entry) => {`
`137`	`137`
`138`		`- const path = entry.path;`
`139`		`- const childPkg = entry.childPkg;`
	`138`	`+ const { path, childPkg } = entry;`
`140`	`139`	`const name = entry.childPkg.name;`
`141`	`140`
`142`	`141`	`if (allowScripts[name] === undefined) {`
`@@ -155,7 +154,7 @@ exports.run = async (options) => {`
`155`	`154`	`}`
`156`	`155`
`157`	`156`	`if (!Semver.validRange(allowScripts[name])) {`
`158`		- errors.push(`${name} (invalid semver range)`);
	`157`	+ errors.push(`${name} (invalid semver range: ${allowScripts[name]})`);
`159`	`158`	`return;`
`160`	`159`	`}`
`161`	`160`