Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Making dora_cli::command public #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Making dora_cli::command public #1142

wants to merge 2 commits into from

Conversation

@haixuanTao
Copy link
Collaborator

@haixuanTao haixuanTao commented Sep 16, 2025 •
edited by phil-opp
Loading

This PR is a cherry pick of the bigger #1093.

It allows to program the cli from within Rust.

Alternative to #1101

phil-opp
phil-opp approved these changes Sep 16, 2025
View reviewed changes
Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, but can we add a doc comment to the crate that we don't follow semver for the dora-cli crate? Otherwise, we would need to do a minor version bump whenever we add or change a field of some CLI command struct.

@phil-opp
Copy link
Collaborator

There seem to be some sdist issues on the CI.

@phil-opp phil-opp changed the title Making command public Making dora_cli::command public Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@haixuanTao @phil-opp