-
Notifications
You must be signed in to change notification settings - Fork 1.9k
BuildAndVerify.ps1 and Agent Improvements (Issue-Resolver, PR-Reviewer & Test-Repro) #33151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I want to ensure you're able to run the hostapp ps1 script on github copilot successfully I want to make sure you can run the ps1 script and get validate output about if something doesn't compile Linux can build android targets so it should be fine for running and building with the android tfms Can you run the ps1 script and then report back the errors you get when running it |
I successfully ran the BuildAndRunHostApp.ps1 script validation on Linux with Android TFM. Here are the results: Compilation Error Found and Fixed ✅Error: Root Cause: Fix (commit f41aa92):
Build Validation Results✅ Android (net10.0-android): Build succeeded with 0 warnings, 0 errors Script Accessibility✅ The PowerShell script is accessible and executable The HostApp now compiles successfully for Android targets on Linux. |
|
@copilot did you need to update the ps1 script at all? Or is the ps1 script ready to use in your environment ad a way to validate the build? |
No, I didn't need to update the ps1 script at all. The What worked out of the box:
The script is ready to use as a build validation tool without any modifications. |
|
@copilot update description and title to indicate this pr is about fixing instructions and ps1 scripts ro verify build Create a ps1 script similar to existing ps1 scripts that agents use called BuildAndVerify.ps1 The purpose of this is just to verify everything builds before you finish It needs to detect if it's on linux in which case it only builds and Verifies android |
Done! ✅ (commit 8a13e6a) PR Title and Description Updated:
BuildAndVerify.ps1 Created:
Usage: ./BuildAndVerify.ps1 # Build all key projects
./BuildAndVerify.ps1 -Projects "HostApp" # Build specific project |
|
The only parameters this should have should be related to running unit tests The default build should build the hostapp on all available tfms Each uitest project for available platforms And then based on input parameters run all the unit tests as well |
Done! ✅ (commit d13db57) BuildAndVerify.ps1 redesigned: Default behavior (no parameters):
Parameters (unit test related only):
Examples: ./BuildAndVerify.ps1 # Build HostApp + UI tests
./BuildAndVerify.ps1 -RunUnitTests # Build + run all unit tests
./BuildAndVerify.ps1 -RunUnitTests -UnitTestFilter "FullyQualifiedName~Core"Tested on Linux - builds HostApp (Android) and Android UI tests successfully. |
|
@copilot remove unit tests filter We want to keep this simple |
|
Please run all permutations of this script and verify the output is what you expect please |
Co-authored-by: PureWeen <[email protected]>
…izingStrategy Co-authored-by: PureWeen <[email protected]>
Co-authored-by: PureWeen <[email protected]>
…nimalGroup Co-authored-by: PureWeen <[email protected]>
…SizingStrategy on iOS Co-authored-by: PureWeen <[email protected]>
Co-authored-by: PureWeen <[email protected]>
…nally run unit tests Co-authored-by: PureWeen <[email protected]>
Co-authored-by: PureWeen <[email protected]>
Co-authored-by: PureWeen <[email protected]>
…AndVerify.ps1 Co-authored-by: PureWeen <[email protected]>
Co-authored-by: PureWeen <[email protected]>
Co-authored-by: PureWeen <[email protected]>
Co-authored-by: PureWeen <[email protected]>
Co-authored-by: PureWeen <[email protected]>
… test instructions Co-authored-by: PureWeen <[email protected]>
…ermine checkpoint stage Co-authored-by: PureWeen <[email protected]>
Co-authored-by: PureWeen <[email protected]>
…it messages Co-authored-by: PureWeen <[email protected]>
….ps1 for running tests Co-authored-by: PureWeen <[email protected]>
…ps1, support both unit and UI tests Co-authored-by: PureWeen <[email protected]>
…on tests only Co-authored-by: PureWeen <[email protected]>
b036cda to
9c209fe
Compare
BuildAndVerify.ps1 and Agent Improvements (Issue-Resolver, PR-Reviewer & Test-Repro)
Description of Change
This PR adds
BuildAndVerify.ps1, a PowerShell script that enables automated build verification before finalizing changes, and improves multiple agents by consolidating duplicated content and enhancing their workflows. Also introduces a new specialized test-repro-agent for creating issue reproduction tests.BuildAndVerify.ps1 Script
Purpose:
Default Behavior:
TestCases.HostAppon all available TFMs (target frameworks)Optional Features:
-RunUnitTestsflag runs all unit tests after building-Configurationparameter supports Debug/Release buildsParameters
-RunUnitTests(switch) - Run all unit tests after building (default: false)-Configuration(string) - Build configuration: "Debug" or "Release" (default: Debug)Usage Examples
New: Test-Repro-Agent
Purpose: Specialized agent for creating issue reproduction tests ONLY (does NOT implement fixes)
Key Features:
When to use:
Workflow:
Issue-Resolver Agent Improvements
Consolidation and Enhancements:
.github/instructions/uitests.instructions.mdPR-Reviewer Agent Improvements
Consolidation and Enhancements:
Key Workflow Changes
Test-Repro-Agent (NEW):
Issue-Resolver:
PR-Reviewer:
Validation & Testing
All permutations tested successfully on Linux:
Error detection verified:
Documentation Updates
.github/README-AI.md:.github/copilot-instructions.md:.github/agents/issue-resolver.md:.github/agents/pr-reviewer.md:.github/agents/test-repro-agent.md: (NEW)Files Changed
.github/scripts/BuildAndVerify.ps1- New build verification script (250+ lines).github/README-AI.md- Added script documentation.github/copilot-instructions.md- Added Build Verification section.github/agents/issue-resolver.md- Consolidated workflow (~369 lines changed, 218 removed).github/agents/pr-reviewer.md- Autonomous validation workflow (~185 lines changed).github/agents/test-repro-agent.md- NEW: Specialized reproduction test creation agent (327 lines)Issues Fixed
N/A - This PR provides build verification tooling and improves agent instructions for GitHub Copilot agents.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.