LSP - LanguageServerProjectLoader - Why is BuildHostProcessManager not reused? #81571
Unanswered
MattParkerDev
asked this question in
Q&A
Replies: 1 comment
-
|
We're creating one BuildHostProcessManager for a single batch of builds: so if you open a solution and it's got 20 projects, we're going to create one process (per "kind" of host) for all those 20 loads. Those processes are reused by the manager, generally. At that point we shut down the process until we would have to do a later reload. Why don't we keep it around? Honestly I'm not sure it's worth it, and the logic to deal with when to unload any of that cached state would add extra complexity. Was there a problem you're seeing here or just curious? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
roslyn/src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/LanguageServerProjectLoader.cs
Line 166 in 3c291cc
Why doesn't the BuildHostProcessManager, (and therefore the msbuild processes), get reused?
Unless I am misunderstanding, it seems inefficient to create a new process every time you need to load the project in msbuild, especially since msbuild does a bunch of caching for incremental stuff?
Beta Was this translation helpful? Give feedback.
All reactions