Thanks to visit codestin.com
Credit goes to github.com

Skip to content

AllToAll should return both particle and hole #23

@evanberkowitz

Description

@evanberkowitz

In most measurements that require propagators, like SpinSpinCorrelator and DeterminantCorrelators one has to pass a particle AND a hole propagator. It would be much simpler if the propagator.AllToAll returned just a dict from species to propagators.

Right now SingleParticleCorrelator takes just one species. But usually, you call it twice (see measure.py), once for particles, once for holes. So we could clean that up similarly, allowing just one call in measure.py` by passing the dict.

The only concern is speed---requiring an inverse for both species means the user always pays for both. We could add another measurement propagator.OneSpecies (or something like it).

This would be a breaking change, but not difficult to implement.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions