Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@roihershberg
Copy link
Contributor

@roihershberg roihershberg commented May 14, 2022

  • Duplicate MainActivity, settings fragment and realted files.
  • Add a setting to toggle between UIs and an activity launcher that launches the corresponding activity.
  • Resolve DI and ToxService's notification intent
  • Change the new theme to be based on material design.

@robinlinden
Copy link
Collaborator

I don't think we should preemptively duplicate the majority of the codebase. Why is it needed?

@roihershberg
Copy link
Contributor Author

roihershberg commented May 15, 2022

It is for the freedom of changing everything that is related to UI. We need another MainActivity so we can change the nav host however we like as well as all the fragments.
What would you do different?

Edit: Maybe we can indeed just duplicate things one by one when it is needed.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.

@roihershberg
Copy link
Contributor Author

You can use the "Compare with" functionality in Android Studio to see what changes have been made after I have duplicated a file. For example, you can select in the project tree both SettingsFragment.kt via the Ctrl key and then click Ctrl+D and you will see what I have changed.

* Duplicate MainActivity, settings fragment and realted files.
* Add a setting to toggle between UIs and an activity launcher that
  launches the corresponding activity.
* Resolve DI and ToxService's notification intent
* Change the new theme to be based on material design.
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants