Thanks to visit codestin.com
Credit goes to github.com

Skip to content

* #401: Updated to the virtual-schema-common-jdbc:6.1.0 #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 17, 2020
Merged

* #401: Updated to the virtual-schema-common-jdbc:6.1.0 #403

merged 12 commits into from
Nov 17, 2020

Conversation

@AnastasiiaSergienko
Copy link
Contributor

@AnastasiiaSergienko AnastasiiaSergienko commented Nov 4, 2020 •
edited
Loading

Closes #401

@AnastasiiaSergienko AnastasiiaSergienko added the refactoring Code improvement without behavior change label Nov 4, 2020
@AnastasiiaSergienko AnastasiiaSergienko self-assigned this Nov 4, 2020
redcatbear
redcatbear requested changes Nov 5, 2020
View reviewed changes
exanm
exanm suggested changes Nov 6, 2020
View reviewed changes
redcatbear
redcatbear previously approved these changes Nov 9, 2020
View reviewed changes
@exanm exanm self-requested a review November 9, 2020 16:19
exanm
exanm suggested changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@exanm exanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review all of the getStringLiteral implementations because of missing documentation links.

exanm
exanm suggested changes Nov 10, 2020
View reviewed changes
exanm
exanm previously approved these changes Nov 12, 2020
View reviewed changes
exanm
exanm previously approved these changes Nov 13, 2020
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

85.9% 85.9% Coverage
0.4% 0.4% Duplication

@AnastasiiaSergienko AnastasiiaSergienko merged commit 731a777 into master Nov 17, 2020
@AnastasiiaSergienko AnastasiiaSergienko deleted the enhancement/401_update_to_the_latest_common_jdbc branch November 17, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@redcatbear redcatbear redcatbear left review comments

+1 more reviewer

@exanm exanm exanm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@AnastasiiaSergienko AnastasiiaSergienko

Labels

refactoring Code improvement without behavior change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update to the latest common-jdbc

4 participants

@AnastasiiaSergienko @redcatbear @exanm