Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@EBKH
Copy link
Contributor

@EBKH EBKH commented Oct 4, 2018

Created the action to allow to add a repo to a team

@EBKH
Copy link
Contributor Author

EBKH commented Oct 4, 2018

FYI, this action works with the dependencies updated, but the test keep failing

@coveralls
Copy link

coveralls commented Oct 4, 2018

Coverage Status

Coverage increased (+0.3%) to 91.339% when pulling d380d86 on valiot:EBKH/Add-team-to-repo into 93b4dfc on edgurgel:master.

@ghost
Copy link

ghost commented Oct 4, 2018

Tests pass for me, both in the branch and having run git merge master.

@edgurgel
Copy link
Owner

edgurgel commented Oct 4, 2018

Ok so this test doesn't depend on the dependency updates? How about we just keep that PR separated from this one?

@EBKH
Copy link
Contributor Author

EBKH commented Oct 4, 2018

@edgurgel Yes, that was what I intented. So I do rebase and avoid the updates again?

@edgurgel
Copy link
Owner

edgurgel commented Oct 5, 2018

I would rebase and keep just the new code to add a repo to a team, if that's ok?

@EBKH EBKH force-pushed the EBKH/Add-team-to-repo branch from 3476727 to 1590860 Compare October 5, 2018 18:11
@EBKH
Copy link
Contributor Author

EBKH commented Oct 5, 2018

@edgurgel Done :)

@EBKH EBKH changed the title Add a repo to a team EBKH/Add a repo to a team Oct 5, 2018
@edgurgel edgurgel merged commit 82ea38f into edgurgel:master Oct 7, 2018
@edgurgel
Copy link
Owner

edgurgel commented Oct 7, 2018

@EBKH awesome! Thank you! For the update of dependencies I think it's something with exvcr 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants