Tentacat.Client.new - force a check of cred type #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every time I come back to this library I make the same mistake and it costs my hours to debug.
I instantiate the client like so :
`c = Tentacat.Client.new("my secret github token" )`
Rather than :
`c = Tentacat.Client.new( %{access_token: "my secret github token" }`
This PR is an attempt to prevent others from making a similar mistake.
Author
|
Just to clarify - So it fails instantly if I pass an incorrect structure when instantiating the client. |
Owner
|
@bryanhuntesl, thanks! I think it makes total sense to validate this 👍 |
ghost
commented
Oct 16, 2018
|
|
||
| test "default endpoint" do | ||
| client = new(%{}) | ||
| client = new() |
Author
There was a problem hiding this comment.
So when communicating with github - providing no credentials is acceptable.
ghost
commented
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time I come back to this library I make the same mistake and it costs my hours to debug.
I instantiate the client like so :
c = Tentacat.Client.new("my secret github token" )Rather than :
c = Tentacat.Client.new( %{access_token: "my secret github token" }This PR is an attempt to prevent others from making a similar mistake.