Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@leisterfrancisco
Copy link
Collaborator

@leisterfrancisco leisterfrancisco commented Aug 5, 2022

What does this PR do?

  • Create new action setdistpct to modify monthly_distribution_pct
  • Remove HCD rank as a paid rank, excepting the edge case when an election only took 1 round
  • Add a new unit test to validate the new distribution and validate that the monthly_distribution_pct update is done as expected
  • Update FE to avoid showing the HCD as a paid rank for elections with more than 1 round

General Notes

  • HCD rank is not paid
  • HCD rank may receive a small fraction of tokens when distributions are not equally divisible between paid ranks, then HCD rank will receive those tokens
  • setdistpct action can only receive values between 1 to 15

@netlify
Copy link

netlify bot commented Aug 5, 2022

Deploy Preview for eden-dev failed.

Name Link
🔨 Latest commit e893a44
🔍 Latest deploy log https://app.netlify.com/sites/eden-dev/deploys/62ecb50ef0d9d4000843f37d

@leisterfrancisco leisterfrancisco changed the base branch from main to dev August 5, 2022 13:30
Copy link

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 008400e into dev Aug 8, 2022
@xavier506 xavier506 deleted the feat/disbursement branch August 8, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants