Build wheels for more architectures #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that's some crazy long build times. any way to speed it up? |
|
I guess it's the ppc64 arch that blew up the build time. We could just drop it. I genuinely have no idea if anyone still uses power pc. |
380ee1b to
e8d160b
Compare
|
I dropped the ppc64 arch again and also bumped the required python version to 3.9, which cuts down the time a bit as well. |
|
nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more architectures with pre-built wheels. Most importantly, this adds linux-aarch64 and linux-armv7l, which are fairly common platforms.
You can see a test run here: https://github.com/inomotech-foss/bitstruct/actions/runs/14686144725
FYI: On s390x the tests fail: https://github.com/inomotech-foss/bitstruct/actions/runs/14686026768/job/41214698872. I don't think it's a particularly relevant architecture, I just happened to notice it while working on this.