refactor(bin): remove mochawesome reporter #5575

fengmk2 · 2025-10-01T12:38:46Z

Summary by CodeRabbit

Breaking Changes
- Removed support for the mochawesome reporter; the --mochawesome CLI flag is no longer available. Reporter selection now relies on the TEST_REPORTER environment variable.
Documentation
- Updated README to remove the mochawesome reporter option.
Chores
- Removed mochawesome-with-mocha dependency.
- Relaxed dependency versions to caret ranges for c8, mocha, and typescript.
Tests
- Removed tests related to the --mochawesome flag.

coderabbitai · 2025-10-01T12:38:54Z

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Removed mochawesome integration across repo: dependencies deleted, CLI flag and reporter wiring removed, tests and docs updated accordingly. Workspace catalog switched specific versions to caret ranges for c8, mocha, and typescript. Reporter selection in test command now relies solely on TEST_REPORTER environment variable.

Changes

Cohort / File(s)	Summary of changes
Dependency cleanup `package.json`, `tools/egg-bin/package.json`, `pnpm-workspace.yaml`	Removed `mochawesome-with-mocha`. In workspace catalog, changed pinned versions to caret ranges for `c8`, `mocha`, `typescript`; removed `mochawesome-with-mocha` entry.
CLI test command reporter handling `tools/egg-bin/src/commands/test.ts`	Deleted `--mochawesome` flag and all mochawesome wiring (reporter selection/options, parallel registration). Reporter now sourced only from `TEST_REPORTER` env; no fallback injection.
Documentation update `tools/egg-bin/README.md`	Removed bullet describing `--mochawesome` reporter option.
Test update `tools/egg-bin/test/commands/test.test.ts`	Removed test case exercising `--mochawesome`; other tests unchanged.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as Developer
  participant EB as egg-bin Test Command
  participant Env as Environment
  participant Mocha as Mocha Runner

  Dev->>EB: run "egg-bin test"
  EB->>Env: read TEST_REPORTER
  alt Reporter set
    EB->>Mocha: invoke with --reporter=$TEST_REPORTER
  else Reporter not set
    EB->>Mocha: invoke with default Mocha reporter
  end
  Mocha-->>Dev: test results
  note over EB,Mocha: Mochawesome-specific flags/registration removed

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hopped through deps with gentle cheer,
Snipped a shiny report from yesteryear.
Flags fell quiet, env now leads,
Mocha runs light, on simpler seeds.
Carrots caret-sweet, version vines climb—
Tests still thump—right on time. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.
Title Check	✅ Passed	The title clearly summarizes the primary change, namely the removal of the mochawesome reporter from the bin code, and follows a concise conventional commit style indicating a refactor.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch remove-mochawesome

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull Request Overview

This PR removes the mochawesome report functionality from the egg-bin test command by default. The change simplifies the test command by removing the automatic mochawesome HTML report generation that was previously enabled by default.

Key changes:

Removed the --mochawesome flag and its associated logic from the test command
Cleaned up dependencies by removing mochawesome-with-mocha from package.json files
Updated version constraints for some catalog dependencies to use caret ranges

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tools/egg-bin/src/commands/test.ts	Removed mochawesome flag definition and reporter logic
tools/egg-bin/test/commands/test.test.ts	Removed test case for mochawesome functionality
tools/egg-bin/package.json	Removed mochawesome-with-mocha dependency
tools/egg-bin/README.md	Removed documentation for --mochawesome flag
pnpm-workspace.yaml	Removed mochawesome-with-mocha from catalog and updated version constraints
package.json	Removed mochawesome-with-mocha dependency

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

gemini-code-assist · 2025-10-01T12:39:05Z

Summary of Changes

Hello @fengmk2, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the egg-bin testing utility by completely removing the mochawesome test reporter and its associated dependencies. This change streamlines the codebase, reduces the overall package size, and removes a default reporting mechanism that can now be optionally configured by users if needed. The modifications include updates to package configurations, removal of CLI options, and deletion of related test cases.

Highlights

Mochawesome Reporter Removal: The mochawesome-with-mocha dependency and all associated logic for generating mochawesome test reports have been completely removed from the egg-bin testing command.
Dependency Clean-up: The package.json, pnpm-lock.yaml, and pnpm-workspace.yaml files have been updated to reflect the removal of mochawesome-with-mocha and its transitive dependencies, resulting in a leaner dependency tree.
CLI Flag Deprecation: The --mochawesome CLI flag has been removed from the test command in egg-bin, along with its documentation and corresponding test cases, simplifying the command-line interface.
Dependency Version Updates: Minor updates to dependency specifiers (e.g., c8, mocha, typescript) from fixed versions to caret versions have been applied in pnpm-lock.yaml and pnpm-workspace.yaml.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

cloudflare-workers-and-pages · 2025-10-01T12:39:07Z

Deploying egg with Cloudflare Pages

Latest commit:	`3554e94`
Status:	🚫 Build failed.

View logs

cloudflare-workers-and-pages · 2025-10-01T12:39:42Z

Deploying egg-v3 with Cloudflare Pages

Latest commit:	`3554e94`
Status:	🚫 Build failed.

View logs

gemini-code-assist

Code Review

This pull request effectively removes the mochawesome reporter as a default option, which simplifies the testing configuration. The changes are consistent across package.json, lock files, documentation, and source code. I've also noticed the dependency versions for c8, mocha, and typescript have been updated to use caret ranges, which is a good practice for dependency management. I have one suggestion to improve the reporter configuration flexibility in tools/egg-bin/src/commands/test.ts.

tools/egg-bin/src/commands/test.ts

codecov · 2025-10-01T12:42:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.06%. Comparing base (deedf32) to head (3554e94).
⚠️ Report is 2 commits behind head on next.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #5575   +/-   ##
=======================================
  Coverage   81.06%   81.06%           
=======================================
  Files         209      209           
  Lines        5988     5988           
  Branches      876      876           
=======================================
  Hits         4854     4854           
  Misses       1060     1060           
  Partials       74       74

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

refactor(bin): remove mochawesome report by default

3554e94

fengmk2 requested a review from Copilot October 1, 2025 12:38

Copilot AI reviewed Oct 1, 2025

View reviewed changes

fengmk2 mentioned this pull request Oct 1, 2025

4.0 Milestone #3644

Open

47 tasks

gemini-code-assist bot reviewed Oct 1, 2025

View reviewed changes

tools/egg-bin/src/commands/test.ts Show resolved Hide resolved

fengmk2 changed the title ~~refactor(bin): remove mochawesome report by default~~ refactor(bin): remove mochawesome reporter Oct 1, 2025

fengmk2 merged commit d89d165 into next Oct 1, 2025
28 of 34 checks passed

fengmk2 deleted the remove-mochawesome branch October 1, 2025 13:17

coderabbitai bot mentioned this pull request Oct 28, 2025

refactor: remove egg-ts-helper #5657

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(bin): remove mochawesome reporter #5575

refactor(bin): remove mochawesome reporter #5575

Uh oh!

fengmk2 commented Oct 1, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 1, 2025 •

edited

Loading

Other AI code review bot(s) detected

Uh oh!

Copilot AI left a comment

Uh oh!

gemini-code-assist bot commented Oct 1, 2025

Uh oh!

cloudflare-workers-and-pages bot commented Oct 1, 2025

Uh oh!

cloudflare-workers-and-pages bot commented Oct 1, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

codecov bot commented Oct 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

refactor(bin): remove mochawesome reporter #5575

refactor(bin): remove mochawesome reporter #5575

Uh oh!

Conversation

fengmk2 commented Oct 1, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other AI code review bot(s) detected

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

gemini-code-assist bot commented Oct 1, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

cloudflare-workers-and-pages bot commented Oct 1, 2025

Deploying egg with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Oct 1, 2025

Deploying egg-v3 with Cloudflare Pages

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

codecov bot commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fengmk2 commented Oct 1, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 1, 2025 •

edited

Loading

codecov bot commented Oct 1, 2025 •

edited

Loading