-
Notifications
You must be signed in to change notification settings - Fork 178
feat!: bump engines requirement to Node 22
#1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9e52f83 to
bc19e91
Compare
931e82b to
5e5336d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean and good!
BREAKING CHANGE: bumps required Node.js version to >=22.12.0. ESM-only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit regarding indentation in one of the workflows otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for what's been addressed from my last review.
Co-authored-by: David Sanders <[email protected]>
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: bumps required Node.js version to
>=22.12.0. ESM-only.I also took the opportunity to update
farmhashto3.3.1in one of the test fixtures so we can run a couple of test cases we were skipping onarm64macOS. I tried switching to4.0.1but it would require some deeper changes in the tests, so I figured it would be a good idea to address that in a follow-up PR as3.3.1is enough to get those tests running for the Node upgrade.