Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@erikian
Copy link
Member

@erikian erikian commented Jan 16, 2025

BREAKING CHANGE: bumps required Node.js version to >=22.12.0. ESM-only.

I also took the opportunity to update farmhash to 3.3.1 in one of the test fixtures so we can run a couple of test cases we were skipping on arm64 macOS. I tried switching to 4.0.1 but it would require some deeper changes in the tests, so I figured it would be a good idea to address that in a follow-up PR as 3.3.1 is enough to get those tests running for the Node upgrade.

@electron electron deleted a comment from notion-workspace bot Jan 18, 2025
@erikian erikian marked this pull request as ready for review February 10, 2025 02:58
@erikian erikian requested a review from a team as a code owner February 10, 2025 02:59
Copy link
Member

@felixrieseberg felixrieseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean and good!

Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this work!

Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit regarding indentation in one of the workflows otherwise LGTM.

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for what's been addressed from my last review.

Co-authored-by: David Sanders <[email protected]>
@dsanders11 dsanders11 merged commit 8a2a599 into main Apr 30, 2025
4 checks passed
@dsanders11 dsanders11 deleted the feat/node-22 branch April 30, 2025 00:28
@continuous-auth
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants